Add an overload that allows supplying custom stdout and stderr destinations AND a body #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My use case is that I want to be able to point stdout/stderr at the same file descriptor, AND I want to support cancellation. With the current set of overloads I can only do one or the other. |
iCharlesHu
reviewed
Jun 9, 2025
jakepetroules
force-pushed
the
add-missing-overload
branch
2 times, most recently
from
43c0d43 to
70a9e4b
Compare
iCharlesHu
approved these changes
Jun 10, 2025
…ations AND a body Every other combination of stdin/stdout/stderr with a custom body was present except for this one.
jakepetroules
force-pushed
the
add-missing-overload
branch
from
70a9e4b to
091b6f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every other combination of stdin/stdout/stderr with a custom body was present except for this one.